Merged
Conversation
awni
reviewed
Feb 11, 2026
Comment on lines
+142
to
+144
| parser.add_argument( | ||
| "--path", type=str, required=True, help="Path to the MLX model." | ||
| ) |
Member
There was a problem hiding this comment.
nit: wdyt about renaming that to --model to be consistent with other command?
Member
There was a problem hiding this comment.
Although if the intention is this can be used for anything (not just a model) than --path is probably better.
awni
approved these changes
Feb 11, 2026
Member
awni
left a comment
There was a problem hiding this comment.
Very nice! This seems quite useful!
Contributor
|
Nice! No more manual copy and paste across nodes! |
ea4e0a3 to
d776d2d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly putting this to check if people think it's useful. We could also put it in
mlx_lm.manage.This PR introduces a utility called
mlx_lm.sharethat can be used to broadcast models (or any folder/file) from 1 node to the others usingmlx.core.distributed. It is often the case that we download a model on one node and then have to move it to others via external storage or something similar.Thunderbolt 5 with JACCL actually saturates the write bandwidth of the disk so with
mlx_lm.shareI am getting 5-6 GB/s broadcast so no need for external storage to move things around. It would be strictly slower...Examples